Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated methods #253

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Resolve deprecated methods #253

merged 5 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Related with

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Simplification of code in Schema.php
    The developer has added two use statements, likely improving the readability of the code.

  • Optimization of key normalization
    Instead of using the custom method normalizeRowKeyCase(), the universal PHP function array_change_key_case() is now utilized. This step is carried out in multiple sections of the 'Schema.php' file, including within the findColumns method.

  • Change in retrieving raw table name
    In the getCacheKey method, the way database retrieves a raw table name has been modified. Instead of the previous method $this->getRawTableName($name), it now uses $this->db->getQuoter()->getRawTableName($name). This may provide a more accurate or efficient way to get the raw table name.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1d08e72) 98.02% compared to head (e7f78c8) 98.02%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #253   +/-   ##
=========================================
  Coverage     98.02%   98.02%           
  Complexity      175      175           
=========================================
  Files            16       16           
  Lines           556      556           
=========================================
  Hits            545      545           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
@Tigrov Tigrov merged commit 67a21fa into master Feb 10, 2024
20 of 22 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants